chore(sponsored-feeds): use yaml format for the sponsored feed data for EVM #746
+982
−1,477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nidhi-singh02
force-pushed
the
yaml-format-sponsored-feed
branch
from
fdfcd9c to
b731a07
Compare
nidhi-singh02
added
documentation
nidhi-singh02
force-pushed
the
yaml-format-sponsored-feed
branch
from
b731a07 to
bc00d71
Compare
nidhi-singh02
commented
Jul 15, 2025
Comment on lines
+7
to
+11
| const networkImports = { | ||
| ethereum_mainnet: () => | ||
| import( | ||
| "../pages/price-feeds/sponsored-feeds/data/evm/ethereum_mainnet.yaml" | ||
| ), |
There was a problem hiding this comment.
Keeping separate yaml files for each network, so it is easy to access/modify the data.
nidhi-singh02
commented
Jul 15, 2025
| @@ -55,4 +55,4 @@ The addresses represent the price feed account for shard 0 of the relevant price | |||
| | FARTCOIN/USD | `2t8eUbYKjidMs3uSeYM9jXM9uudYZwGkSeTB4TKjmvnC` | `58cd29ef0e714c5affc44f269b2c1899a52da4169d7acc147b9da692e6953608` | | |||
| | ACRED/USD | `6gyQ2TKvvV1JB5oWDobndv6BLRWcJzeBNk9PLQ5uPQms` | `40ac3329933a6b5b65cf31496018c5764ac0567316146f7d0de00095886b480d` | | |||
| | WTI1M/USD | `nt1JuGVRBJNrvMpdZt9RJnxVSxRuoeVx5LRq3R1bS16` | `eca3fb7e6be5be55a01678ee00f6405b9e4986e32d539ccd2a06a57e0c615880` | | |||
| | PUMP/USD | `HMm3GPbdnqGwbkTnUUqCFsH8AMHDdEC3Lg8gcPD3HJSH` | `7a01fca212788bba7c5bf8c9efd576a8a722f070d2c17596ff7bb609b8d5c3b9` | | |||
| | PUMP/USD | `HMm3GPbdnqGwbkTnUUqCFsH8AMHDdEC3Lg8gcPD3HJSH` | `7a01fca212788bba7c5bf8c9efd576a8a722f070d2c17596ff7bb609b8d5c3b9` | | |||
There was a problem hiding this comment.
This change is unrelated to this PR, it is from precommit prettier for merged changes.
aditya520
reviewed
Jul 15, 2025
| priceDeviation: number; | ||
| } | ||
| // Import the data for each network. The data is in the form of a yaml file. | ||
| const networkImports = { |
There was a problem hiding this comment.
Rather than importing all networks here, can't you make a component which will take the yaml on run?
| import { useState } from "react"; | ||
| import copy from "copy-to-clipboard"; | ||
|
|
||
| export const useCopyToClipboard = (timeout: number = 2000) => { |
There was a problem hiding this comment.
Can't we abstract this method and use it with copyAddress?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same yaml format as defined in the deployments repository so it is easy to update when a price feed data changes.
Type of Change
Areas Affected
There is no change in the UI. It remains the same as before.
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots